fix: authenticate GitHub API calls to avoid rate limit failures#27
Merged
fix: authenticate GitHub API calls to avoid rate limit failures#27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI builds intermittently fail when
github-release-install.sh(andgithub-release-url.sh) call the GitHub API unauthenticated to fetch the latest release forfrostyard/updex. Shared GitHub Actions runner IPs hit the 60 req/hour unauthenticated limit, causingcurl --failto exit non-zero and fail the build.Solution
Pass
github.token(5,000 req/hour) as a build secret so the API calls are authenticated. Graceful degradation is preserved: ifGITHUB_TOKENis absent (local builds), the secret mount is skipped and curl runs unauthenticated as before.Changes
github-release-install.sh/github-release-url.sh— read/run/secrets/GITHUB_TOKENif present and pass-H "Authorization: Bearer …"to curlContainerfile— add--mount=type=secret,id=GITHUB_TOKENto theRUNinstruction (requireddefaults tofalse, so absent secret is a no-op)Justfile— conditionally append--secret id=GITHUB_TOKEN,env=GITHUB_TOKENtoBUILD_ARGSwhenGITHUB_TOKENis set in the environment.github/workflows/build-image.yml— exposeGITHUB_TOKEN: ${{ github.token }}on the Build Image step sosudo env PATH="$PATH"forwards it tojust